pan3793 commented on code in PR #7017:
URL: https://github.com/apache/kyuubi/pull/7017#discussion_r2034962551
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/ui/JettyServer.scala:
##########
@@ -49,7 +52,10 @@ private[kyuubi] class JettyServer(
case _ =>
}
}
- def getServerUri: String = connector.getHost + ":" + connector.getLocalPort
+
+ @volatile private var _serverUri: String = _
+ def getServerUri: String =
+ Option(_serverUri).getOrElse(connector.getHost + ":" +
connector.getLocalPort)
Review Comment:
can we at least log some warning message in `getOrElse` block, to indicate
the Jetty server has not been started?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
