pan3793 commented on code in PR #7021:
URL: https://github.com/apache/kyuubi/pull/7021#discussion_r2042041074
##########
kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/api/v1/dto/KyuubiSessionEvent.java:
##########
@@ -45,6 +45,8 @@ public class KyuubiSessionEvent {
private Map<String, String> conf;
+ private Map<String, String> optimizedConf;
Review Comment:
I had an offline discussion with @cxzl25 a long time ago about this naming
issue, the current state is a mess and did cause some issues. Maybe we should
have a clear and fixed name for some confs, for example
- serverConf - hold by SessionManager on the server side
- engineConf - hold by SessionManager on the engine side
- sessionConf - the eventually effective conf for a session
for those normalizedConf, and optimizedConf, which are the intermediate
concepts of implementation details that should not be exposed to users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
