pan3793 commented on code in PR #7039:
URL: https://github.com/apache/kyuubi/pull/7039#discussion_r2059495155
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ApplicationOperation.scala:
##########
@@ -129,6 +129,33 @@ object ApplicationInfo {
val UNKNOWN: ApplicationInfo = ApplicationInfo(null, null,
ApplicationState.UNKNOWN)
}
+class KubernetesApplicationInfo(
+ id: String,
+ name: String,
+ state: ApplicationState,
+ url: Option[String] = None,
+ error: Option[String] = None,
+ val podName: String) extends ApplicationInfo(id, name, state, url, error) {
Review Comment:
extending case class is tricky, seems that we can simply add a field
podName: `Option[String]` to `ApplicationInfo`, and leave a comment: only used
for K8s, even for K8s cases, still possible to be None for cases like NOT_FOUND
state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
