turboFei commented on code in PR #7033:
URL: https://github.com/apache/kyuubi/pull/7033#discussion_r2062545923
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala:
##########
@@ -566,8 +566,9 @@ object KubernetesApplicationOperation extends Logging {
case Some(containerAppState) => containerAppState
case None => podAppState
}
- val applicationError =
- if (ApplicationState.isFailed(applicationState)) {
+ val applicationError = {
+ // here the applicationState could not been NOT_FOUND, safe to use None
ApplicationOperation
+ if (ApplicationState.isFailed(applicationState, appOperation = None)) {
Review Comment:
resolved.
```
def isFailed(state: ApplicationState, supportPersistedAppState: Boolean):
Boolean = state match {
case FAILED => true
case KILLED => true
case NOT_FOUND => supportPersistedAppState
case _ => false
}
```
Here invoke:
```
ApplicationState.isFailed(applicationState, supportPersistedAppState = true)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
