flaming-archer commented on code in PR #4528:
URL: https://github.com/apache/kyuubi/pull/4528#discussion_r2097465005
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/read/HiveScanBuilder.scala:
##########
@@ -37,6 +37,8 @@ case class HiveScanBuilder(
catalogTable = table,
dataSchema = dataSchema,
readDataSchema = readDataSchema(),
- readPartitionSchema = readPartitionSchema())
+ readPartitionSchema = readPartitionSchema(),
+ partitionFilters = partitionFilters,
+ dataFilters = dataFilters)
Review Comment:
> Yes, `dataFilters` has no effect on correctness.
>
> KSHC does not support pushdown filters to file sources, so, in fact, both
`dataFilters` and `pushedFilters` are useless.
PushedFilters don't used either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
