pan3793 commented on PR #7095: URL: https://github.com/apache/kyuubi/pull/7095#issuecomment-2964788736
Change itself LGTM, but can we have meaningful names for those three `buildBatch` methods? at least with some comments to explain the differences, it isn't very clear now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org
