pan3793 commented on code in PR #7134:
URL: https://github.com/apache/kyuubi/pull/7134#discussion_r2203503553
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiStatement.java:
##########
@@ -124,23 +129,25 @@ public KyuubiStatement(
@Override
public void cancel() throws SQLException {
- checkConnection("cancel");
- if (isCancelled) {
- return;
- }
-
try {
+ checkConnection("cancel");
+ if (isCancelled) {
+ return;
+ }
+ stmtHandleChangeLock.lock();
Review Comment:
I think you should check isCancelled again after obtaining the lock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
