turboFei commented on code in PR #7143:
URL: https://github.com/apache/kyuubi/pull/7143#discussion_r2217976449
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -326,4 +381,40 @@ class KyuubiSessionImpl(
if (client.engineConnectionClosed) return false
!client.remoteEngineBroken
}
+
+ private def isTimedOut: Boolean = {
+ lastAccessTime + sessionIdleTimeoutThreshold <= System.currentTimeMillis &&
+ getNoOperationTime > sessionIdleTimeoutThreshold
+ }
+
+ private def setState(newState: SessionState): Unit = {
+ SessionState.validateTransition(state, newState)
+ newState match {
+ case SessionState.RUNNING =>
+ info(s"Session is ready.")
Review Comment:
this kind of log is meaningless without session identifier
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -326,4 +381,40 @@ class KyuubiSessionImpl(
if (client.engineConnectionClosed) return false
!client.remoteEngineBroken
}
+
+ private def isTimedOut: Boolean = {
+ lastAccessTime + sessionIdleTimeoutThreshold <= System.currentTimeMillis &&
+ getNoOperationTime > sessionIdleTimeoutThreshold
+ }
+
+ private def setState(newState: SessionState): Unit = {
+ SessionState.validateTransition(state, newState)
+ newState match {
+ case SessionState.RUNNING =>
+ info(s"Session is ready.")
+ case SessionState.ERROR | SessionState.TIMEOUT | SessionState.CLOSED =>
+ info(s"Session is terminated.")
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
