1358035421 commented on code in PR #7158:
URL: https://github.com/apache/kyuubi/pull/7158#discussion_r2234789129
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/session/AbstractSession.scala:
##########
@@ -56,7 +56,12 @@ abstract class AbstractSession(
if (lastIdleTime > 0) System.currentTimeMillis() - _lastIdleTime else 0
}
- override val sessionIdleTimeoutThreshold: Long =
sessionManager.getConf.get(SESSION_IDLE_TIMEOUT)
+ override val sessionIdleTimeoutThreshold: Long = {
+ conf.get(SESSION_IDLE_TIMEOUT.key)
+ .map(_.toLong)
+ .getOrElse(
+ sessionManager.getConf.get(SESSION_IDLE_TIMEOUT))
+ }
Review Comment:
Thank you very much for your reply and suggestions, @turboFei!
Your comments reminded me that it would actually be more appropriate to make
the changes in
(https://github.com/apache/kyuubi/blob/master/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/session/SparkSessionImpl.scala)
so that the behavior only affects Spark, and does not impact other engines.
I haven't participated in the implementation or testing of other engines, so
I'm not sure whether they have similar issues related to session idle timeout.
Do you know if other engines also allow users to override session idle
timeout in a way that could affect their stability, or is this only specific to
Spark?
Thanks again for your advice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
