pan3793 commented on code in PR #7171:
URL: https://github.com/apache/kyuubi/pull/7171#discussion_r2313811824
##########
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/DiscoveryClient.scala:
##########
@@ -62,9 +62,14 @@ trait DiscoveryClient extends Logging {
def pathExists(path: String): Boolean
/**
- * Check if the path non exists.
- */
- def pathNonExists(path: String): Boolean
+ * Checks whether the given path and all its child paths (prefix matches) do
not exist.
+ * The isPrefix is set to true by default for Etcd to retrieve all entries
under the given path.
+ * For other discovery service, it can be set false by default to only check
the exact path.
+ * @param path The path to check
Review Comment:
```suggestion
* @param path The path to check
```
##########
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/DiscoveryClient.scala:
##########
@@ -62,9 +62,14 @@ trait DiscoveryClient extends Logging {
def pathExists(path: String): Boolean
/**
- * Check if the path non exists.
- */
- def pathNonExists(path: String): Boolean
+ * Checks whether the given path and all its child paths (prefix matches) do
not exist.
+ * The isPrefix is set to true by default for Etcd to retrieve all entries
under the given path.
+ * For other discovery service, it can be set false by default to only check
the exact path.
+ * @param path The path to check
Review Comment:
```suggestion
*
* @param path The path to check
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
