pan3793 commented on code in PR #7249:
URL: https://github.com/apache/kyuubi/pull/7249#discussion_r2544182560
##########
externals/kyuubi-jdbc-engine/src/test/scala/org/apache/kyuubi/engine/jdbc/starrocks/StarRocksOperationWithEngineSuite.scala:
##########
@@ -75,4 +75,26 @@ class StarRocksOperationWithEngineSuite extends
StarRocksOperationSuite with Hiv
assert(tFetchResultsResp.getStatus.getStatusCode ===
TStatusCode.SUCCESS_STATUS)
}
}
+
+ test("starrocks - JDBC ExecuteStatement operation cancel should kill SQL
statement") {
Review Comment:
same here - StarRocks
##########
externals/kyuubi-jdbc-engine/src/test/scala/org/apache/kyuubi/engine/jdbc/mysql/OperationWithEngineSuite.scala:
##########
@@ -75,4 +75,23 @@ class OperationWithEngineSuite extends MySQLOperationSuite
with HiveJDBCTestHelp
assert(tFetchResultsResp.getStatus.getStatusCode ===
TStatusCode.SUCCESS_STATUS)
}
}
+
+ test("Mysql - JDBC ExecuteStatement operation cancel should kill SQL
statement") {
Review Comment:
use the correct form - "MySQL", not "mySql", "Mysql", or something else
https://www.mysql.com/
operation cancel => cancel operation
##########
externals/kyuubi-jdbc-engine/src/test/scala/org/apache/kyuubi/engine/jdbc/mysql/OperationWithEngineSuite.scala:
##########
@@ -75,4 +75,23 @@ class OperationWithEngineSuite extends MySQLOperationSuite
with HiveJDBCTestHelp
assert(tFetchResultsResp.getStatus.getStatusCode ===
TStatusCode.SUCCESS_STATUS)
}
}
+
+ test("Mysql - JDBC ExecuteStatement operation cancel should kill SQL
statement") {
+ withSessionHandle { (client, handle) =>
+ val tExecuteStatementReq = new TExecuteStatementReq()
+ tExecuteStatementReq.setSessionHandle(handle)
+ tExecuteStatementReq.setStatement("SELECT sleep(1200)")
Review Comment:
what's the unit? seconds? leave a comment here to avoid ambiguity, 1200s are
too crazy, maybe 2min
##########
externals/kyuubi-jdbc-engine/src/test/scala/org/apache/kyuubi/engine/jdbc/starrocks/StarRocksOperationWithEngineSuite.scala:
##########
@@ -75,4 +75,26 @@ class StarRocksOperationWithEngineSuite extends
StarRocksOperationSuite with Hiv
assert(tFetchResultsResp.getStatus.getStatusCode ===
TStatusCode.SUCCESS_STATUS)
}
}
+
+ test("starrocks - JDBC ExecuteStatement operation cancel should kill SQL
statement") {
+ withSessionHandle { (client, handle) =>
+ val tExecuteStatementReq = new TExecuteStatementReq()
+ tExecuteStatementReq.setSessionHandle(handle)
+ tExecuteStatementReq.setStatement("SELECT sleep(1200)")
+ tExecuteStatementReq.setRunAsync(true)
+ val tExecuteStatementResp = client.ExecuteStatement(tExecuteStatementReq)
+
+ // todo:we need to improvement the cancel mechanism in starrocks server
side,
+ // once a query submitted, we should be able to cancel it immediately.
Review Comment:
it's unclear to me what the current behavior is from the words, and if you
have StarRocks side issues/PR links, please leave them here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
