turboFei commented on code in PR #7262:
URL: https://github.com/apache/kyuubi/pull/7262#discussion_r2609124720
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -190,7 +192,18 @@ class KyuubiRestFrontendService(override val serverable:
Serverable)
val batchId = batchSession.batchJobSubmissionOp.batchId
try {
val task: Future[Unit] = batchRecoveryExecutor.submit(() =>
-
Utils.tryLogNonFatalError(sessionManager.openBatchSession(batchSession)))
+ Utils.tryLogNonFatalError {
+ sessionManager.openBatchSession(batchSession)
+ if (recoveryWaitEngineSubmission) {
+ info(s"Waiting for batch[$batchId] engine submission during
recovery")
+ val batchOp = batchSession.batchJobSubmissionOp
+ while
(batchSession.getSessionEvent.forall(_.exception.isEmpty) &&
+ !batchOp.appStarted &&
+ !OperationState.isTerminal(batchOp.getStatus.state)) {
+ Thread.sleep(300)
Review Comment:
```
val BATCH_APPLICATION_STARVATION_TIMEOUT: ConfigEntry[Long] =
buildConf("kyuubi.batch.application.starvation.timeout")
.doc("Threshold above which to warn batch application may be starved.")
.version("1.7.0")
.timeConf
.createWithDefault(Duration.ofMinutes(3).toMillis)
```
We already had this config.
https://github.com/apache/kyuubi/blob/05d063737e328990bdaad6aad1758cbe24e2e1c6/kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala#L307-L311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
