Yao-MR commented on PR #7280: URL: https://github.com/apache/kyuubi/pull/7280#issuecomment-3681819129
> It looks like a break change. > > I saw you want to enable the authentication for metrics port. > > How about using the reflection to inject the AuthenticationFilter in kyuubi-metrics module? > > https://github.com/apache/kyuubi/blob/63095f05372dd532e3d3c3b3841bf74fac7ad756/kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala#L120-L121 > > Please add an config item for the new feature and disable it by defaults. @turboFei yes, it is a break change , and also we can use reflection to reslove this for reuse, but there is a problem that all the class releated with authoration is in the server module, and the reflection will be complexed and not easy to read what is your idea? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
