pan3793 commented on code in PR #7294:
URL: https://github.com/apache/kyuubi/pull/7294#discussion_r2659278634


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -180,6 +180,9 @@ class KyuubiSessionImpl(
             _engineSessionHandle =
               engineClient.openSession(protocol, user, passwd, 
openEngineSessionConf)
             _client = engineClient
+            if (isClosed) {
+              throw KyuubiSQLException(s"KyuubiSession $handle has been 
closed")

Review Comment:
   is the retry meaningless for this case? if so, you should set `shouldRetry = 
false`, and carefully check if `_client` is going to be closed properly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to