pan3793 commented on code in PR #7307:
URL: https://github.com/apache/kyuubi/pull/7307#discussion_r2693746446
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/dialect/MySQLDialect.scala:
##########
@@ -60,8 +64,11 @@ class MySQLDialect extends JdbcDialect {
filters += s"$TABLE_CATALOG = '$catalog'"
}
- if (StringUtils.isNotBlank(schema)) {
+ // when DBeaver connect use %, kyuubi to return all tables from all other
databases.
+ if (StringUtils.isNotBlank(schema) && !"%".equals(schema)) {
Review Comment:
I don't understand this change, I suppose `WHERE $TABLE_SCHEMA LIKE '%'` has
the same effect as an empty condition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
