pan3793 commented on code in PR #7320:
URL: https://github.com/apache/kyuubi/pull/7320#discussion_r2780117737
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala:
##########
@@ -376,9 +376,11 @@ class JDBCMetadataStore(conf: KyuubiConf) extends
MetadataStore with Logging {
setClauses += "engine_state = ?"
params += metadata.engineState
}
- metadata.engineError.foreach { error =>
+ // Update engineError when it's defined or when engineId is defined
+ // This ensures pending reasons are cleared when app transitions to success
Review Comment:
> ... when app transitions to success
the code does not reflect the condition. is there a chance that the batch
transfers to another negative state and clears the error message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
