pan3793 commented on code in PR #7324:
URL: https://github.com/apache/kyuubi/pull/7324#discussion_r2792893433
##########
kyuubi-server/src/test/scala/org/apache/kyuubi/engine/spark/SparkSqlEngineSuite.scala:
##########
@@ -149,5 +151,38 @@ class SparkSqlEngineSuite extends WithKyuubiServer with
HiveJDBCTestHelper {
}
}
+ test("KYUUBI-7323: Support timeout at PlanOnlyMode") {
Review Comment:
Kyuubi uses GitHub Issues instead of JIRA, use `KYUUBI #XXXX` instead of
`KYUUBI-XXXX` for issue/PR reference.
Also, we don't require creating an issue before sending a PR, GitHub Issues
and PRs share the sequence number, and the link can jump to each other, so
`XXXX` can either be an issue number or a PR number. What really matters here,
clear description of the context of your change - especially WHY, and TEST.
WHAT is also important in most cases, but for cases where the code itself is
self-explanatory, WHAT is optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
