LamiumAmplexicaule commented on code in PR #7349:
URL: https://github.com/apache/kyuubi/pull/7349#discussion_r2923587463
##########
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/HighAvailabilityConf.scala:
##########
@@ -106,12 +106,27 @@ object HighAvailabilityConf {
.version("1.3.2")
.fallbackConf(KyuubiConf.SERVER_PRINCIPAL)
+ val HA_ZK_ENGINE_AUTH_PRINCIPAL: ConfigEntry[Option[String]] =
+ buildConf("kyuubi.ha.zookeeper.engine.auth.principal")
+ .doc("Kerberos principal name that is used for the engine's ZooKeeper
authentication." +
+ "It fallback to `kyuubi.ha.zookeeper.auth.principal`")
Review Comment:
Thank you for pointing that out.
I’ve fixed it in commit
https://github.com/apache/kyuubi/pull/7349/changes/b8622214f2719fe82aff8b8ca122ae036f4aa93f.
##########
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/HighAvailabilityConf.scala:
##########
@@ -106,12 +106,27 @@ object HighAvailabilityConf {
.version("1.3.2")
.fallbackConf(KyuubiConf.SERVER_PRINCIPAL)
+ val HA_ZK_ENGINE_AUTH_PRINCIPAL: ConfigEntry[Option[String]] =
+ buildConf("kyuubi.ha.zookeeper.engine.auth.principal")
+ .doc("Kerberos principal name that is used for the engine's ZooKeeper
authentication." +
+ "It fallback to `kyuubi.ha.zookeeper.auth.principal`")
+ .version("1.12.0")
+ .fallbackConf(HighAvailabilityConf.HA_ZK_AUTH_PRINCIPAL)
+
val HA_ZK_AUTH_KEYTAB: ConfigEntry[Option[String]] =
buildConf("kyuubi.ha.zookeeper.auth.keytab")
.doc("Location of the Kyuubi server's keytab that is used for ZooKeeper
authentication.")
.version("1.3.2")
.fallbackConf(KyuubiConf.SERVER_KEYTAB)
+ val HA_ZK_ENGINE_AUTH_KEYTAB: ConfigEntry[Option[String]] =
+ buildConf("kyuubi.ha.zookeeper.engine.auth.keytab")
+ .doc("Location of the Kyuubi server's keytab that is used for " +
+ "the engine's ZooKeeper authentication." +
+ "It fallback to `kyuubi.ha.zookeeper.auth.keytab`")
Review Comment:
Thank you for pointing that out.
I’ve fixed it in commit
https://github.com/apache/kyuubi/pull/7349/changes/b8622214f2719fe82aff8b8ca122ae036f4aa93f.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
