aajisaka commented on code in PR #7474:
URL: https://github.com/apache/kyuubi/pull/7474#discussion_r3315514081
##########
externals/kyuubi-data-agent-engine/src/test/java/org/apache/kyuubi/engine/dataagent/runtime/middleware/CompactionMiddlewareLiveTest.java:
##########
@@ -46,10 +47,10 @@ public class CompactionMiddlewareLiveTest {
private OpenAIClient client;
- @Before
+ @BeforeEach
public void setUp() {
- assumeTrue("DATA_AGENT_OPENAI_API_KEY not set, skipping live tests",
!API_KEY.isEmpty());
- assumeTrue("DATA_AGENT_OPENAI_ENDPOINT not set, skipping live tests",
!BASE_URL.isEmpty());
+ assumeTrue(!API_KEY.isEmpty(), "DATA_AGENT_OPENAI_API_KEY not set,
skipping live tests");
+ assumeTrue(!BASE_URL.isEmpty(), "DATA_AGENT_OPENAI_ENDPOINT not set,
skipping live tests");
Review Comment:
Nit: Not directly related to the migration, but it can be simplified to
`assumeFalse(API_KEY.isEmpty(), ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
