ylq5126 commented on PR #7463: URL: https://github.com/apache/kyuubi/pull/7463#issuecomment-4569808981
> I noticed the existing Oracle tests are failing after this change. Oracle `INTEGER` seems to be exposed by ojdbc as `NUMBER(*,0)` / `NUMERIC` with scale 0, and its reported precision may not match `precision <= 9`, so it now falls through to DECIMAL. That changes `resultSet.getObject()` from an integer-like value to `BigDecimal(1)`, causing the assertions in `OracleStatementSuite` to fail. > > Would it make sense to add regression tests for the boundary cases, e.g. `INTEGER`, `NUMBER(9,0)`, `NUMBER(10,0)`, and `NUMBER(20,0)`? Maybe we can also consider whether `NUMBER(10..18,0)` should map to BIGINT rather than DECIMAL. I will create a new merge request later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
