ruanwenjun commented on code in PR #7486:
URL: https://github.com/apache/kyuubi/pull/7486#discussion_r3439705876
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala:
##########
@@ -664,6 +664,7 @@ object KubernetesApplicationOperation extends Logging {
applicationState,
supportPersistedAppState = true) || applicationState ==
ApplicationState.PENDING) {
val errorMap = containerStatusToBuildAppState.map { cs =>
+ pod.getStatus.setContainerStatuses(Seq.empty.asJava)
Review Comment:
I’m a bit concerned about mutating the pod object here. It might be safer to
filter or mask containerStatuses only when logging, in case any upstream code
relies on the original pod status.
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala:
##########
@@ -664,6 +664,7 @@ object KubernetesApplicationOperation extends Logging {
applicationState,
supportPersistedAppState = true) || applicationState ==
ApplicationState.PENDING) {
val errorMap = containerStatusToBuildAppState.map { cs =>
+ pod.getStatus.setContainerStatuses(Seq.empty.asJava)
Review Comment:
I’m a bit concerned about mutating the pod object here. It might be safer to
filter or mask containerStatuses only when logging, in case any upstream code
relies on the original pod status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
