maomaodev commented on code in PR #7476:
URL: https://github.com/apache/kyuubi/pull/7476#discussion_r3788098091
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/HiveTable.scala:
##########
@@ -109,10 +107,24 @@ case class HiveTable(
override def newScanBuilder(options: CaseInsensitiveStringMap): ScanBuilder
= {
convertedProvider match {
case Some("ORC") if
sparkSession.sessionState.conf.getConf(READ_CONVERT_METASTORE_ORC) =>
- OrcScanBuilder(sparkSession, fileIndex, schema, dataSchema, options)
+ new KyuubiOrcScanBuilder(
+ sparkSession,
+ fileIndex,
+ schema,
+ dataSchema,
+ options,
+ catalogTable,
+ hiveTableCatalog)
case Some("PARQUET")
if
sparkSession.sessionState.conf.getConf(READ_CONVERT_METASTORE_PARQUET) =>
- ParquetScanBuilder(sparkSession, fileIndex, schema, dataSchema,
options)
+ new KyuubiParquetScanBuilder(
Review Comment:
Documented the tradeoff both in the source (class-level scaladoc of
`KyuubiParquetScan` / `KyuubiOrcScan`, point 3) and added a paragraph to the PR
description: KSHC-converted Parquet/ORC tables fall back to JVM reads under
Gluten/Comet. A dedicated escape-hatch config can follow up if a real user hits
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
