wangzhigang1999 commented on PR #7656: URL: https://github.com/apache/kyuubi/pull/7656#issuecomment-5419562053
I ran four targeted JDK 21 tests against the server-side `TBinaryFrontendService`: idle sessions, operation lifecycle, query-log fetching, and expected-error logging. Each test used a 60-second warm-up and a 300-second measurement window. With JFR pin detection set to 1 ms, all four recordings reported zero `VirtualThreadPinned` events, with no failures or carrier starvation. JFR did show monitor contention in synchronous Log4j output, especially during error logging, but it did not cause pinning in these tests. Kyuubi already uses Log4j 2.26.1, whose output path remains synchronized, so upgrading Log4j would not change this. Since the feature is opt-in, I suggest keeping this PR unchanged and documenting that slow synchronous logging sinks may still pose a risk on JDK 21. These results apply only to the server frontend; engine-side virtual threads would require a separate and more cautious evaluation because they enter longer-running SQL, extension, and external I/O paths. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
