wForget commented on PR #7616: URL: https://github.com/apache/kyuubi/pull/7616#issuecomment-6050799783
> Thank you @wForget. I think the root cause analysis is right. However, does moving the `conf.set` into `start` regress `DELETE /engine?kill=true` feature introduced in #6008? The reason is, `SparkProcessBuilder.commands` is cached and the command line is materialized on first access (`EngineRef.create`) before calling `start`, so the engine command line no longer have the `appMgrInfo`. > > My suggestion is to make `SparkProcessBuilder.sparkHome` a lazy val instead of moving the `conf.set` to avoid the regression. Thanks @aajisaka , that makes sense, I wil make `SparkProcessBuilder.sparkHome` a lazy val. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
