pan3793 commented on code in PR #7775:
URL: https://github.com/apache/kyuubi/pull/7775#discussion_r4269089971
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/tableExtractors.scala:
##########
@@ -52,10 +55,14 @@ object TableExtractor {
* @return owner
*/
def getOwner(v: AnyRef): Option[String] = {
- // org.apache.spark.sql.connector.catalog.Table
- val table = invokeAs[AnyRef](v, "table")
- val properties = invokeAs[JMap[String, String]](table,
"properties").asScala
- properties.get("owner")
+ // It holds the properties itself, rather than wrapping another table.
Review Comment:
show move this comment to the V1Table branch?
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/tableExtractors.scala:
##########
@@ -52,10 +55,14 @@ object TableExtractor {
* @return owner
*/
def getOwner(v: AnyRef): Option[String] = {
- // org.apache.spark.sql.connector.catalog.Table
- val table = invokeAs[AnyRef](v, "table")
- val properties = invokeAs[JMap[String, String]](table,
"properties").asScala
- properties.get("owner")
+ // It holds the properties itself, rather than wrapping another table.
Review Comment:
should move this comment to the V1Table branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
