[
https://issues.apache.org/jira/browse/LIBCLOUD-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963579#comment-13963579
]
ASF GitHub Bot commented on LIBCLOUD-518:
-----------------------------------------
GitHub user tomprince opened a pull request:
https://github.com/apache/libcloud/pull/275
[LIBCLOUD-518] Automatically detect domain of Elastic IPs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hybridlogic/libcloud 518-detect-ec2-domain
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/275.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #275
----
commit 5bc911de3c71e329b3e9d877ac84191b3c1b99ac
Author: Tom Prince <[email protected]>
Date: 2014-04-08T21:40:52Z
[LIBCLOUD-518] Automatically detect domain of Elastic IPs.
----
> EC2NodeDriver.ex_associate_address_with_node's domain parameter is redundante
> -----------------------------------------------------------------------------
>
> Key: LIBCLOUD-518
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-518
> Project: Libcloud
> Issue Type: Bug
> Components: Compute
> Reporter: Tom Prince
> Labels: ec2, vpc
>
> Whether an address and/or instance is in a VPC can be determined from
> attributes, so the value of the parameter must have can be determined from
> other arguments. (There can also be sanity checking, to ensure that a classic
> EIP isn't associated to a VPC instance, or vice-versa).
> ex_disassociate_address should also get this treatement.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
