[ 
https://issues.apache.org/jira/browse/LIBCLOUD-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127231#comment-14127231
 ] 

ASF GitHub Bot commented on LIBCLOUD-612:
-----------------------------------------

GitHub user sfriesel opened a pull request:

    https://github.com/apache/libcloud/pull/356

    [LIBCLOUD-612] Customize HTTP vendor prefix for Google Storage

    https://issues.apache.org/jira/browse/LIBCLOUD-612
    
    Google storage uses/expects custom headers like meta data
    and storage class to be prefixed with "x-goog" instead of
    "x-amz". This enables use of object tagging in the Google
    Storage provider.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sfriesel/libcloud gs_meta_data

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #356
    
----
commit 4b4ed2b578f12387f7abafabacbd8ff9164e598f
Author: Stefan Friesel <[email protected]>
Date:   2014-09-09T16:23:34Z

    Customize HTTP vendor prefix for Google Storage
    
    Google storage uses/expects custom headers like meta data
    and storage class to be prefixed with "x-goog" instead of
    "x-amz". This enables use of object tagging in the Google
    Storage provider.

----


> Google Storage: tags can't be read/written
> ------------------------------------------
>
>                 Key: LIBCLOUD-612
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-612
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Storage
>            Reporter: Stefan Friesel
>            Priority: Minor
>
> Setting tags via upload_object(..., extra=dict(meta_data={...})) and reading 
> them via get_object('foo').meta_data doesn't work in the Google Storage 
> driver. From what I see in the code this is caused by 
> BaseS3StorageDriver._headers_to_object, which expects the meta data headers 
> to be prefixed with 'x-amz-meta-'. I checked the libcloud debug output and on 
> Google Storage they are prefixed with 'x-goog-meta-'.
> Should the Google driver override the method (although it's private) or 
> should BaseS3StorageDriver._headers_to_object accept both prefixes? Or 
> something else? Depending on what the preferred solution is, I would make a 
> pullrequest for this.
> Is there ongoing work to have a Google Storage Driver using the native Google 
> API?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to