[
https://issues.apache.org/jira/browse/LIBCLOUD-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228010#comment-14228010
]
ASF GitHub Bot commented on LIBCLOUD-638:
-----------------------------------------
GitHub user pzrq opened a pull request:
https://github.com/apache/libcloud/pull/404
[LIBCLOUD-638] Can't set CORS headers via
container.upload_object_via_stream()
I can't find a reopen link on:
https://github.com/apache/libcloud/pull/403
So here we go again:
https://issues.apache.org/jira/browse/LIBCLOUD-638
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mathspace/libcloud 638_cors_headers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/404.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #404
----
commit d453ef99bffdeaa7c41f5fb76a5df6985ddce2ae
Author: Peter Schmidt <[email protected]>
Date: 2014-11-27T00:20:38Z
Remove misleading .
commit a1b078b729e0f68bbc83cd56ed51bbf8b70726e1
Author: Peter Schmidt <[email protected]>
Date: 2014-11-27T00:20:57Z
Typo: fill instead of will.
commit 5c9ad396f54b90912cefe272f68df5fc1b5926fe
Author: Peter Schmidt <[email protected]>
Date: 2014-11-27T03:01:07Z
[LIBCLOUD-638] Add, document and test for headers to
``upload_object_via_stream``, and similar methods to enable supporting CORS (or
other) headers in the cloudfiles driver:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#Access-Control-Allow-Origin
http://docs.rackspace.com/files/api/v1/cf-devguide/content/Assigning_CORS_Headers_to_Requests-d1e2120.html
commit 599f33a5eaff7408a7bc577f3863f302fe98e5e7
Author: Peter Schmidt <[email protected]>
Date: 2014-11-27T03:44:47Z
Document something that affects a full usage of a bytes iterator but I have
no idea on the correct fix for.
e.g. bytes(37) returns 37 null bytes...
commit bf0ef50dfc83e1a78c60f080cabe07faddaa9d71
Author: Peter Schmidt <[email protected]>
Date: 2014-11-27T05:05:43Z
Consistently order as :param arg: then :type arg: (if there's a higher
level coding convention I'll happily swap the other half of this file instead).
commit 56a17105d0de5da1f164ac3e0e9c134ae99c5d1f
Author: Peter Schmidt <[email protected]>
Date: 2014-11-28T00:14:11Z
Get Python <=2.6 access to assertDictEqual(). Thanks @Kami
https://github.com/apache/libcloud/pull/403/files#r20989150
commit 124bde50cb4bdc49166db8703bc32bb7b2c7582d
Author: Peter Schmidt <[email protected]>
Date: 2014-11-28T00:20:49Z
Good pick up - it would be nice if the test was less fragile, e.g. someone
accidentally commented out that NotImplementedError and any other issues that
arise. Thanks @Kami
https://github.com/apache/libcloud/pull/403/files#r20989215
----
> Can't set CORS headers via container.upload_object_via_stream()
> ---------------------------------------------------------------
>
> Key: LIBCLOUD-638
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-638
> Project: Libcloud
> Issue Type: New Feature
> Components: Storage
> Reporter: Peter Schmidt
>
> Would be nice to have the ability to set Cross-Origin Resource Sharing (CORS)
> headers, and probably other headers too when using
> `container.upload_object_via_stream()` without subclassing and overriding
> several lower level functions.
> References:
> https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#Access-Control-Allow-Origin
> http://docs.rackspace.com/files/api/v1/cf-devguide/content/Assigning_CORS_Headers_to_Requests-d1e2120.html
> Ran into this migrating a project from Rackspace cloudfiles which allows
> setting of CORS headers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
