GitHub user Kami opened a pull request:
https://github.com/apache/libcloud/pull/639
Add "ttl" attribute to the libcloud.dns.base.Record class
This pull request adds new `ttl` attribute to the
`libcloud.dns.base.Record` class. Class constructor has also been updated to
reflect this change - this attribute has been added as an optional argument
before `extra`.
Next step will be updating `{create,update}_record` methods so they also
accept `ttl` argument. This way user doesn't need to mess with `extra['ttl']`
and we provide a stronger and better API (something we should have done from
the beginning).
As mentioned in the upgrade notes - this change is backward incompatible if
the user manually instantiated `Record` class without using keyword arguments.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Kami/libcloud dns_api_record_change
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/639.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #639
----
commit 59049a68923391b42b371b27bd3799af2e04d133
Author: Tomaz Muraus <[email protected]>
Date: 2015-11-22T22:21:18Z
Add "ttl" attribute to the Record class.
commit 1c4e89112bca03137e737948998993fa4350c120
Author: Tomaz Muraus <[email protected]>
Date: 2015-11-22T22:21:35Z
Update affected DNS drivers to pass "ttl" attribute to the Record class
constructor where available an applicable.
Note: For backward compatibility reasons, "ttl" is still available in
record.extra.
commit 4d7fd3f3c58fd4dd32512a9a72af471ab3a52b3a
Author: Tomaz Muraus <[email protected]>
Date: 2015-11-22T22:30:13Z
Remove print stament which some how ended up there.
commit e756b5e6ec6798cf8a43f6a69886c0dcf5db40bc
Author: Tomaz Muraus <[email protected]>
Date: 2015-11-22T22:40:14Z
Update upgrade notes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
