GitHub user teemuvesala opened a pull request:
https://github.com/apache/libcloud/pull/770
[LIBCLOUD-811] Fix to mishandled shopper_id at GoDaddy DNS Driver
Link to the issue tracked:
https://issues.apache.org/jira/browse/LIBCLOUD-811
## Changes Title (replace this with a logical title for your changes)
### Description
GoDaddy DNS driver was not handling shopper id properly. The X-Shopper-Id
which is supposed to tell the shopper id was change to True. For that reason
the whole GoDaddy driver was unusable. The fix aws to add
_ex_connection_class_kwargs method to GoDaddyDNSDriver. Arguments of
GoDaddyDNSConnection constructor were reordered.
### Status
Done, ready for review
### Checklist (tick everything that applies)
- [ x ] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [ ] Documentation
- [ x ] [Tests] (They were executed)
(http://libcloud.readthedocs.org/en/latest/testing.html)
- [ NA ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/teemuvesala/libcloud
LIBCLOUD-811_broken_shopper_id
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/770.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #770
----
commit 4cfda9c7fd99a23eae071cde8b80827ab51d0a00
Author: Teemu Vesala <[email protected]>
Date: 2016-04-20T11:44:11Z
[LIBCLOUD-811] Added the _ex_connection_class_kwargs way to handle dynamic
parametrs at GoDaddyDNSDriver.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
