[
https://issues.apache.org/jira/browse/LIBCLOUD-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249724#comment-15249724
]
ASF GitHub Bot commented on LIBCLOUD-811:
-----------------------------------------
GitHub user teemuvesala opened a pull request:
https://github.com/apache/libcloud/pull/770
[LIBCLOUD-811] Fix to mishandled shopper_id at GoDaddy DNS Driver
Link to the issue tracked:
https://issues.apache.org/jira/browse/LIBCLOUD-811
## Changes Title (replace this with a logical title for your changes)
### Description
GoDaddy DNS driver was not handling shopper id properly. The X-Shopper-Id
which is supposed to tell the shopper id was change to True. For that reason
the whole GoDaddy driver was unusable. The fix aws to add
_ex_connection_class_kwargs method to GoDaddyDNSDriver. Arguments of
GoDaddyDNSConnection constructor were reordered.
### Status
Done, ready for review
### Checklist (tick everything that applies)
- [ x ] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [ ] Documentation
- [ x ] [Tests] (They were executed)
(http://libcloud.readthedocs.org/en/latest/testing.html)
- [ NA ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/teemuvesala/libcloud
LIBCLOUD-811_broken_shopper_id
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/770.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #770
----
commit 4cfda9c7fd99a23eae071cde8b80827ab51d0a00
Author: Teemu Vesala <[email protected]>
Date: 2016-04-20T11:44:11Z
[LIBCLOUD-811] Added the _ex_connection_class_kwargs way to handle dynamic
parametrs at GoDaddyDNSDriver.
----
> GoDaddy driver mishandling shopper ID parameter
> -----------------------------------------------
>
> Key: LIBCLOUD-811
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-811
> Project: Libcloud
> Issue Type: Bug
> Components: DNS
> Environment: This has been tested with following operating systems
> and Python versions:
> Windows 7: Python 2.7 and Python 3.0
> Linux: Python 2.7
> Reporter: Teemu Vesala
>
> GoDaddy driver is not able to do any action because it sets the
> 'X-Shopper-Id' header to 'True'. After that all requests to GoDaddy API are
> resulting:
> {"code":"NOT_FOUND","message":"Resource not found","name":"ApiError"}
> Log output from driver.list_zones():
> # -------- begin 3069020076 request ----------
> curl -i -X GET -H 'Host: api.godaddy.com' -H 'X-Shopper-Id: True' -H
> 'Accept-Encoding: gzip,deflate' -H 'X-LC-Request-ID: 3069020076' -H
> 'Authorization: sso-key ACCESS KEY:SECRET KEY' -H 'User-Agent:
> libcloud/1.0.0-rc2 (GoDaddy DNS) ' --compress
> https://api.godaddy.com:443/v1/domains/
> # -------- begin 3069020076:3069040908 response ----------
> HTTP/1.1 404 Not Found
> Via: 1.1 api.godaddy.com
> X-Powered-By: Express
> Transfer-Encoding: chunked
> Vary: Origin,Accept-Encoding
> Connection: close
> Etag: W/"45-K7cRahIguKtXFPRJXsuOkg"
> Access-Control-Allow-Credentials: true
> Date: Wed, 20 Apr 2016 06:51:54 GMT
> Content-Type: application/json; charset=utf-8
> 45
> {"code":"NOT_FOUND","message":"Resource not found","name":"ApiError"}
> 0
> # -------- end 3069020076:3069040908 response ----------
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
