updates code to pep8 standards, uses urlencode to support different python versions
Closes #787 Signed-off-by: Tomaz Muraus <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/10b7c2b3 Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/10b7c2b3 Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/10b7c2b3 Branch: refs/heads/trunk Commit: 10b7c2b35310e36191ef3b9a4adbddf86c66fcad Parents: 4617707 Author: oltjano <[email protected]> Authored: Sun May 15 18:01:27 2016 -0700 Committer: Tomaz Muraus <[email protected]> Committed: Wed May 25 14:37:47 2016 +0200 ---------------------------------------------------------------------- libcloud/dns/drivers/dnspod.py | 17 +++++++++-------- libcloud/test/dns/test_dnspod.py | 2 +- 2 files changed, 10 insertions(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/libcloud/blob/10b7c2b3/libcloud/dns/drivers/dnspod.py ---------------------------------------------------------------------- diff --git a/libcloud/dns/drivers/dnspod.py b/libcloud/dns/drivers/dnspod.py index 4d8838a..59a1e8b 100644 --- a/libcloud/dns/drivers/dnspod.py +++ b/libcloud/dns/drivers/dnspod.py @@ -21,6 +21,7 @@ from libcloud.dns.types import Provider, ZoneDoesNotExistError, \ from libcloud.dns.base import DNSDriver, Zone, Record, RecordType from libcloud.common.dnspod import DNSPodConnection, DNSPodResponse, \ DNSPodException +from libcloud.utils.py3 import urlencode __all__ = [ 'DNSPodDNSDriver' @@ -56,7 +57,7 @@ class DNSPodDNSDriver(DNSDriver): def list_zones(self): action = '/Domain.List' data = {'user_token': self.key, 'format': 'json'} - data = urllib.urlencode(data) + data = urlencode(data) try: response = self.connection.request(action=action, method='POST', data=data) @@ -77,7 +78,7 @@ class DNSPodDNSDriver(DNSDriver): """ action = '/Domain.Remove' data = {'user_token': self.key, 'format': 'json', 'domain_id': zone.id} - data = urllib.urlencode(data) + data = urlencode(data) try: self.connection.request(action=action, method='POST', @@ -99,7 +100,7 @@ class DNSPodDNSDriver(DNSDriver): """ action = '/Domain.Info' data = {'user_token': self.key, 'format': 'json', 'domain_id': zone_id} - data = urllib.urlencode(data) + data = urlencode(data) try: response = self.connection.request(action=action, method='POST', @@ -138,7 +139,7 @@ class DNSPodDNSDriver(DNSDriver): data = {'user_token': self.key, 'format': 'json', 'domain': domain} if extra is not None: data.update(extra) - data = urllib.urlencode(data) + data = urlencode(data) try: response = self.connection.request(action=action, method='POST', data=data) @@ -168,7 +169,7 @@ class DNSPodDNSDriver(DNSDriver): action = '/Record.List' data = {'user_token': self.key, 'format': 'json', 'domain_id': zone.id} - data = urllib.urlencode(data) + data = urlencode(data) try: response = self.connection.request(action=action, data=data, method='POST') @@ -195,7 +196,7 @@ class DNSPodDNSDriver(DNSDriver): action = '/Record.Remove' data = {'user_token': self.key, 'format': 'json', 'domain_id': record.zone.id, 'record_id': record.id} - data = urllib.urlencode(data) + data = urlencode(data) try: self.connection.request(action=action, method='POST', data=data) @@ -228,7 +229,7 @@ class DNSPodDNSDriver(DNSDriver): action = '/Record.Info' data = {'user_token': self.key, 'format': 'json', 'domain_id': zone_id, 'record_id': record_id} - data = urllib.urlencode(data) + data = urlencode(data) try: response = self.connection.request(action=action, method='POST', data=data) @@ -285,7 +286,7 @@ class DNSPodDNSDriver(DNSDriver): # extra = {'ttl': '13', 'record_line': default, 'mx': 1} if extra is not None: to_post.update(extra) - data = urllib.urlencode(to_post) + data = urlencode(to_post) try: response = self.connection.request(action=action, method='POST', http://git-wip-us.apache.org/repos/asf/libcloud/blob/10b7c2b3/libcloud/test/dns/test_dnspod.py ---------------------------------------------------------------------- diff --git a/libcloud/test/dns/test_dnspod.py b/libcloud/test/dns/test_dnspod.py index 7fcc4da..20518ad 100644 --- a/libcloud/test/dns/test_dnspod.py +++ b/libcloud/test/dns/test_dnspod.py @@ -8,7 +8,7 @@ from libcloud.test.secrets import DNS_PARAMS_DNSPOD from libcloud.dns.drivers.dnspod import DNSPodDNSDriver from libcloud.utils.py3 import httplib from libcloud.dns.types import ZoneDoesNotExistError, ZoneAlreadyExistsError,\ - RecordType, RecordDoesNotExistError, RecordAlreadyExistsError + RecordType, RecordDoesNotExistError, RecordAlreadyExistsError from libcloud.dns.base import Zone, Record
