GitHub user jbaublitz opened a pull request:
https://github.com/apache/libcloud/pull/798
GCE: Add support for creating multiple nodes on a subnetwork
## Add support for creating multiple nodes on a subnetwork
### Description
Currently for GCE, the multi node creation API does not support creating
multiple nodes on a subnetwork. I have made changes to the
ex_create_multiple_nodes function and the functions it calls to support
creation of nodes on a given subnetwork. If subnetwork is None, the changes
fall back to legacy network behavior on GCE so it is backwards compatible.
There was one change to _create_node_req that was needed to get disk types
which is simply passing in the location provided as an argument to
ex_get_disktype.
### Status
- ready for review
### Checklist (tick everything that applies)
- [X] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [ ] Documentation
- [X] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbaublitz/libcloud subnet_multi_nodes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/798.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #798
----
commit e5909a48590bec6ed0d7230926a597fcd6589b3f
Author: John Baublitz <[email protected]>
Date: 2016-06-01T23:40:18Z
Fix to allow multiple node creation with subnets
commit 9548531631be7b2e6e5cd1a8f1527eb2a9d9877b
Author: John Baublitz <[email protected]>
Date: 2016-06-02T16:01:39Z
Fix flake8 suggestion
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
