GitHub user allardhoeve opened a pull request:

    https://github.com/apache/libcloud/pull/857

    Create volume is more robust on newer OpenStacks

    ## Make create_volume more robust on newer OpenStacks
    
    ### Description
    
    On newer OpenStacks, things will fail if you do not provide `location` or 
if you do not provide `ex_volume_type`. The driver will pass the default `None` 
values to `self.driver.request`, which serializes them to `null`, which is an 
invalid value for `/os-volumes/` on newer incarnations of OpenStack.
    
    This PR makes it so the OpenStack driver does not include these fields if 
they are None, so they are not refused by OpenStack's validation.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
    - [ ] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [x] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ByteInternet/libcloud 
create_volume_is_more_robust

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/857.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #857
    
----
commit 42d069e6d7255ab11d233e76ae34acdc942e7901
Author: Allard Hoeve <allardho...@gmail.com>
Date:   2016-09-16T15:17:19Z

    Create volume is more robust on newer OpenStacks

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to