[
https://issues.apache.org/jira/browse/LIBCLOUD-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15852877#comment-15852877
]
ASF GitHub Bot commented on LIBCLOUD-893:
-----------------------------------------
GitHub user bennettaur opened a pull request:
https://github.com/apache/libcloud/pull/982
Fix for LIBCLOUD-893
## Fix LIBCLOUD-893 NoneType error
### Description
This fixes a bug introduced into libcloud.security that caused a NoneType
error to be throw if the certifi package was installed and set to be used (by
default if it is installed it is automatically used)
### Status
done, ready for review
### Checklist (tick everything that applies)
- [ ] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SecurityCompass/libcloud fix_LIBCLOUD-893
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/982.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #982
----
commit b40861150b66fa11a4a6faa0a6718d907b13b068
Author: Michael Bennett <[email protected]>
Date: 2017-02-04T17:54:28Z
Fixed a NoneType error being thrown in libcloud.security when certify is
installed (LIBCLOUD-893)
----
> Having certifi installed breaks libcloud.security.py for 2.0.0rc1
> -----------------------------------------------------------------
>
> Key: LIBCLOUD-893
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-893
> Project: Libcloud
> Issue Type: Bug
> Reporter: Michael Bennett
> Priority: Minor
>
> This change:
> https://github.com/apache/libcloud/commit/a4ad8d4a44dbf6069d924cdadabfff522ed703e6
> Causes libcloud.security to fail on import when the certifi package is
> installed. CA_CERTS_PATH was initialized to None however with certifi
> installed, line 58 attempts to insert the certifi_ca_bundle_path and throws a
> NoneType error
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
