GitHub user gargpankaj83 opened a pull request:
https://github.com/apache/libcloud/pull/1070
Issue LIBCLOUD-921: Pass function arguments as **kwargs
to preserve the oder in case of insecure connection
## Insecure (http) connection results in crash for Docker Container Driver
### Description
In the case of insecure http connection to docker engine, when secret key
is not passed to the connect method, the list of arguments and the function
signature will mis-match and result in error.
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [*] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gargpankaj83/libcloud
LIBCLOUD-921_fix_crash_for_insecure_docker_engine_connection
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1070.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1070
----
commit 5ccf64b8b0be50c6639b946eaa8bd5aa232df62e
Author: Pankaj Garg <[email protected]>
Date: 2017-06-15T07:06:59Z
Issue LIBCLOUD-921: Pass function arguments as **kwargs
to preserve the oder in case of insecure connection
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
