GitHub user uty opened a pull request:

    https://github.com/apache/libcloud/pull/1075

    Fix Node.extra having incomplete block_device_mapping on EC2

    ##  Fix `Node.extra` having incomplete `block_device_mapping` on EC2
    
    ### Description
    
    Fix node's Block Device Mapping was parsed from incorrect mapping.
    
[EbsInstanceBlockDevice](http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_EbsInstanceBlockDevice.html)
 is different from  
[EbsBlockDevice](http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_EbsBlockDevice.html).
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
    - [ ] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Scalr/libcloud for-upstream/ec2-instance-bdm

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1075.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1075
    
----
commit 9a950fde80ce383d3dbd8a937f9d8ddb2f0b3edb
Author: Hennadii Stas <uty.arrg...@gmail.com>
Date:   2017-06-14T15:31:56Z

    FAM-966 fixed block_device_mapping parsing in node's extra

commit 8b9ab72c72afe8b7ee0b4e6dec03438977a79371
Author: Hennadii Stas <uty.arrg...@gmail.com>
Date:   2017-06-19T10:59:47Z

    FAM-966 unittests improved

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to