[
https://issues.apache.org/jira/browse/LIBCLOUD-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058776#comment-16058776
]
ASF GitHub Bot commented on LIBCLOUD-458:
-----------------------------------------
GitHub user ayleph opened a pull request:
https://github.com/apache/libcloud/pull/1076
Add SSL URI support for LIBCLOUD-458
Add an optional argument to retrieve the x-cdn-ssl-uri of a Cloud Files
container.
## Changes Title (replace this with a logical title for your changes)
### Description
Replace this with the PR description (mention the changes you have made, why
you have made them, provide some background and any references to the
provider
documentation if needed, etc.).
For more information on contributing, please see
[Contributing](http://libcloud.readthedocs.org/en/latest/development.html#contributing)
section of our documentation.
### Status
Replace this: describe the PR status. Examples:
- work in progress
- done, ready for review
### Checklist (tick everything that applies)
- [ ] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ayleph/libcloud trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1076.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1076
----
commit e7a3ade5dc69d1953831d57a9c0fc2f1ba2b0b67
Author: ayleph <[email protected]>
Date: 2017-06-22T05:13:17Z
Add SSL URI support for LIBCLOUD-458
Add an optional argument to retrieve the x-cdn-ssl-uri of a Cloud Files
container.
----
> Use HTTPS CDN URIs for Rackspace Cloud Files
> --------------------------------------------
>
> Key: LIBCLOUD-458
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-458
> Project: Libcloud
> Issue Type: Improvement
> Components: Storage
> Affects Versions: 0.14.0-beta3
> Reporter: Michael Farrell
>
> I found another patch in my collection, where I had patched the Rackspace
> storage driver to use the HTTPS CDN URI.
> I'm unsure if it may be best to have this as an option for storage drivers,
> but if this option is added, it will also need to be implemented for the
> other storage drivers. I would like some advice on this.
> The patch that hard codes it to use HTTPS URIs always for the CDN, as a
> 1-line change (ie: without the settings proposed above):
> {code}
> -------------------- libcloud/storage/drivers/cloudfiles.py
> --------------------
> index 1502a33..6e7f931 100644
> @@ -273,7 +273,7 @@ class CloudFilesStorageDriver(StorageDriver,
> OpenStackDriverMixin):
> cdn_request=True)
>
> if response.status == httplib.NO_CONTENT:
> - cdn_url = response.headers['x-cdn-uri']
> + cdn_url = response.headers['x-cdn-ssl-uri']
> return cdn_url
> elif response.status == httplib.NOT_FOUND:
> raise ContainerDoesNotExistError(value='',
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
