GitHub user jhelie reopened a pull request:
https://github.com/apache/libcloud/pull/1080
Fix issues found with lgtm
### Description
This fixes more issues flagged by lgtm.com code queries. Most were
minor/style but a few were errors meaning the code did not have the intended
effected (e.g. ```if x == a or b``` instead of ```if (x == a) or (x == b)```
The standard lgtm deep code analysis highlights dependencies,
vulnerabilities (3 found, see
https://lgtm.com/projects/g/apache/libcloud/vulnerabilities) and currently flag
156 alerts - but you can investigate further by writing custom queries to
explore your code base (https://lgtm.com/docs/ql/about-ql).
(PR integration can also help automatically check for potential issues -
for instance I haven't looked into it yet but it seems that
2a450e4072c0468440877ec3decf3b21eaf369fa may have introduced a few potential
issues
https://lgtm.com/projects/g/apache/libcloud/rev/2a450e4072c0468440877ec3decf3b21eaf369fa
)
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [x ] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jhelie/libcloud fix-alerts-found-with-lgtm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1080.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1080
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
