[ 
https://issues.apache.org/jira/browse/LIBCLOUD-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118264#comment-16118264
 ] 

ASF GitHub Bot commented on LIBCLOUD-870:
-----------------------------------------

GitHub user lrvan opened a pull request:

    https://github.com/apache/libcloud/pull/1090

    [LIBCLOUD-870] Implement create methods for AWS ALB driver

    ## Implemented create methods for AWS ALB driver
    
    ### Description
    
    1) Implemented AWS ALB driver methods to create application load balancer 
or its parts:
    - create_balancer
    - ex_create_balancer
    - ex_create_target_group
    - ex_register_targets
    - ex_create_listener
    - ex_create_listener_rule
    
    2) Fixed parameter/field names/types in some methods to be uniform across 
the driver.
    3) Extended _to_#object_type# methods to fetch and return additional data 
about the object from AWS response.
    
    ### Status
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lrvan/libcloud LIBCLOUD-870

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1090.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1090
    
----
commit 95e51d7653a17b2453765eca1f08008489b964a4
Author: Anton Kozyrev <anton.kozy...@gmail.com>
Date:   2017-07-26T14:04:03Z

    [LIBCLOUD-870] create_balancer & ex_create_balancer methods for ALB driver

commit 14d096cd407d87bbd198b2f5dd1fce97601668c6
Author: Anton Kozyrev <anton.kozy...@gmail.com>
Date:   2017-07-26T14:28:54Z

    [LIBCLOUD-870] tests for ALB ex_create_balancer method

commit a4a5baebc827dd1d02aa392a18f93d8a453e540c
Author: Anton Kozyrev <anton.kozy...@gmail.com>
Date:   2017-07-27T10:51:45Z

    [LIBCLOUD-870] new ex_create_target_group ALB method and additional target 
group data collection in _to_target_group

commit 3e00500f6be0b9e20f2acdb897785ab5d86fc36b
Author: Anton Kozyrev <anton.kozy...@gmail.com>
Date:   2017-07-27T11:19:17Z

    [LIBCLOUD-870] ex_register_targets method for ALB

commit f5d7f7110424b3e50be1fb941278b1f3f503e23d
Author: Anton Kozyrev <anton.kozy...@gmail.com>
Date:   2017-07-27T11:49:21Z

    [LIBCLOUD-870] new ex_create_listener ALB method and additional listener 
data in _to_listener

commit 3d8f053646d8c5ac4005b44d8543b7a628638717
Author: Anton Kozyrev <anton.kozy...@gmail.com>
Date:   2017-07-27T12:44:27Z

    [LIBCLOUD-870] new ex_create_listener_rule method

commit 4453d3770d549251e2da404ea5189395cda5cf52
Author: Anton Kozyrev <anton.kozy...@gmail.com>
Date:   2017-08-01T12:33:48Z

    [LIBCLOUD-870] cosmetic refactoring in alb.py

commit 0f3db7e39d924ed6c9167a10da6fb3fe5da74615
Author: Anton Kozyrev <anton.kozy...@gmail.com>
Date:   2017-08-01T14:27:41Z

    [LIBCLOUD-870] test fixtures for ALB driver

commit 0433db30247b7b7777b66a6e2ae75d9ee15ae945
Author: Anton Kozyrev <anton.kozy...@gmail.com>
Date:   2017-08-01T14:29:46Z

    [LIBCLOUD-870] tests for alb ex_create_target_group, ex_register_targets, 
ex_create_listener & ex_create_listener_rule methods

commit 370886d4b8b8154299668d15425c37658b94b3a2
Author: Anton Kozyrev <anton.kozy...@gmail.com>
Date:   2017-08-02T10:03:08Z

    [LIBCLOUD-870] disabled test_create_balancer as it depends on 
ex_register_targets

commit a4c2ce9bc20ead45f628b04341a8773f6912a2f6
Author: Anton Kozyrev <anton.kozy...@gmail.com>
Date:   2017-08-08T10:54:24Z

    [LIBCLOUD-870] character fix in target group name

commit 548b3d8fab4107986bc7f056e2dc36a14e89642e
Author: Anton Kozyrev <anton.kozy...@gmail.com>
Date:   2017-08-08T11:11:32Z

    [LIBCLOUD-870] param fix in ex_register_targets

commit b15313e2445692b7dd65322ae7efe8264027d9ba
Author: Anton Kozyrev <anton.kozy...@gmail.com>
Date:   2017-08-08T11:31:31Z

    [LIBCLOUD-870] param name fix in get_balancer

commit b0631840c2578a56a44d017e6a48fdabe2a130e9
Author: Anton Kozyrev <anton.kozy...@gmail.com>
Date:   2017-08-08T12:13:32Z

    [LIBCLOUD-870] tests for create_balancer & ex_register_targets AWS ALB 
driver methods

----


> Implement create methods for AWS ALB driver
> -------------------------------------------
>
>                 Key: LIBCLOUD-870
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-870
>             Project: Libcloud
>          Issue Type: Sub-task
>          Components: LoadBalancer
>            Reporter: Anton Kozyrev
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to