[
https://issues.apache.org/jira/browse/LIBCLOUD-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157877#comment-16157877
]
ASF GitHub Bot commented on LIBCLOUD-944:
-----------------------------------------
GitHub user vongazman opened a pull request:
https://github.com/apache/libcloud/pull/1107
[LIBCLOUD-944] Add support for private IP addresses in GCE instance creation
## Add support for private IP addresses in GCE instance creatio
### Description
GCE driver doesn't currently allow private IPs to be specified when
creating instances. Updated gce.py driver to allow the optional parameter
internal_ip which can be used when creating GCE instances.
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [x] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [x] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vongazman/libcloud LIBCLOUD-944_private_ip
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1107
----
commit 27d79ea671b1d502930719d00cacbd8337be3a8b
Author: Gareth Mcfarlane <[email protected]>
Date: 2017-09-07T10:53:08Z
Add private IP functionality to GCE
----
> Add support for private IP addresses in GCE instance creation
> -------------------------------------------------------------
>
> Key: LIBCLOUD-944
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-944
> Project: Libcloud
> Issue Type: Improvement
> Components: Compute
> Reporter: Gareth McFarlane
> Priority: Minor
>
> GCE supports specifying a private IP address when deploying instances.
> Currently only specifying the external IP of an instance is supported in
> libcloud.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
