[ https://issues.apache.org/jira/browse/LIBCLOUD-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199898#comment-16199898 ]
ASF GitHub Bot commented on LIBCLOUD-954: ----------------------------------------- GitHub user pquentin opened a pull request: https://github.com/apache/libcloud/pull/1127 [LIBCLOUD-954] ec2: Allow cn-north-1 even without pricing ## ec2: Allow cn-north-1 even without pricing ### Description See https://issues.apache.org/jira/browse/LIBCLOUD-954 and https://github.com/apache/libcloud/commit/1e1d77f320a2314e96c79011ab62ee028a835503 @fjros and @duanshiqiang, what do you think? ### Status - done, ready for review ### Checklist (tick everything that applies) - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [ ] Documentation - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/pquentin/libcloud allow-ec-cn-north-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/1127.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1127 ---- commit bd28b40cb960cd6cfc10595d018115265e1ee5a9 Author: Quentin Pradet <quent...@apache.org> Date: 2017-10-11T07:07:45Z [LIBCLOUD-954] ec2: Allow cn-north-1 even without pricing ---- > EC2 driver don't support cn-north-1 > ----------------------------------- > > Key: LIBCLOUD-954 > URL: https://issues.apache.org/jira/browse/LIBCLOUD-954 > Project: Libcloud > Issue Type: Bug > Reporter: Duan Shiqiang > > From 2.1.0, the support of AWS EC2 for region cn-north-1. See this commit: > [Remove cn-north-1 from VALID_EC2_REGIONS list in EC2 compute > driver|https://github.com/apache/libcloud/commit/1e1d77f320a2314e96c79011ab62ee028a835503]. > I don't know why this is happening, please add the support back as we > actually have work load on AWS china region and has been using apache > libcloud for a while. Thx -- This message was sent by Atlassian JIRA (v6.4.14#64029)