[
https://issues.apache.org/jira/browse/LIBCLOUD-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279176#comment-16279176
]
ASF GitHub Bot commented on LIBCLOUD-967:
-----------------------------------------
GitHub user greendog99 opened a pull request:
https://github.com/apache/libcloud/pull/1149
[LIBCLOUD-967] Add support for DigitalOcean tags in list_nodes()
## Add support for DigitalOcean tags in list_nodes()
See: https://issues.apache.org/jira/browse/LIBCLOUD-967
### Description
Digital Ocean droplets can be tagged with multiple tags, such as
"production" or "database", but these tags are not currently returned by
{{list_nodes()}}.
https://www.digitalocean.com/community/tutorials/how-to-tag-digitalocean-droplets
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [x] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [ ] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
### Tests
Added tags to Digital Ocean fixtures and added test to confirm tags are
captured by `list_nodes()`.
```
$ PYTHONPATH=. python3 libcloud/test/compute/test_digitalocean_v2.py
......libcloud/test/compute/test_digitalocean_v2.py:114:
DeprecationWarning: Please use assertRaisesRegex instead.
location=location)
............................
----------------------------------------------------------------------
Ran 34 tests in 0.217s
OK
```
DeprecationWarning in above test was pre-existing and unrelated to this
change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greendog99/libcloud digitalocean_tags
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1149
----
commit 46ed6b19ac7f91dd9387f0c1600f75335a707f6d
Author: Mike Fischer <[email protected]>
Date: 2017-12-05T20:18:42Z
Add support for DigitalOcean tags in list_nodes()
----
> list_nodes() should include tags from DigitalOcean droplets
> -----------------------------------------------------------
>
> Key: LIBCLOUD-967
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-967
> Project: Libcloud
> Issue Type: Improvement
> Components: Compute
> Reporter: Michael Fischer
> Priority: Minor
> Labels: compute, digitalocean
>
> Digital Ocean droplets can be tagged with multiple tags, such as "production"
> or "database", but these tags are not currently returned by {{list_nodes()}}.
> I am about to submit a PR to implement this improvement. This ticket is being
> opened to track any discussion around that PR.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
