[ https://issues.apache.org/jira/browse/LIBCLOUD-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397520#comment-16397520 ]
ASF GitHub Bot commented on LIBCLOUD-985: ----------------------------------------- GitHub user maxlip opened a pull request: https://github.com/apache/libcloud/pull/1181 [LIBCLOUD-985] Add coverage for newer GCE network and subnet options. ## [LIBCLOUD-985] Add coverage for newer GCE network and subnet options. ### Description Addressing [LIBCLOUD-985](https://issues.apache.org/jira/browse/LIBCLOUD-985), PR adds the ability to handle a few newer GCE network and subnet options upon creation. For networks, supports BGP routing mode For subnetworks, supports secondary IP Ranges, Private IP access to GCP APIs See [](https://cloud.google.com/compute/docs/reference/rest/v1/networks/insert) and [https://cloud.google.com/compute/docs/reference/rest/v1/subnetworks/insert](url) ### Status - done, ready for review ### Checklist (tick everything that applies) - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [x] Documentation - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/maxlip/libcloud LIBCLOUD-985_More_Net_SubNet_Options Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/1181.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1181 ---- commit 497820988e1ee5e9abaac4aa5a8655698fa9330b Author: Max <maxlip@...> Date: 2018-03-13T19:12:56Z [LIBCLOUD-985] Add coverage for newer GCE network and subnet creation options. ---- > GCE - Support network routingmode and subnet secondary/internal access options > ------------------------------------------------------------------------------ > > Key: LIBCLOUD-985 > URL: https://issues.apache.org/jira/browse/LIBCLOUD-985 > Project: Libcloud > Issue Type: Improvement > Components: Compute > Environment: N/A > Reporter: Max L > Priority: Minor > > As of 3/2018, Google Cloud APIs support a few more creation flags for > networks and subnetworks. > Networks: BGP Routing mode regional/global > Subnetworks: Secondary IP Ranges, Private IP access to GCP APIs. > It would be good to add coverage for these. -- This message was sent by Atlassian JIRA (v7.6.3#76005)