GitHub user vdloo opened a pull request:

    https://github.com/apache/libcloud/pull/1190

    fix unexpected body type openstack image sharing

    Looks like I introduced a bug here [in this 
PR](https://github.com/apache/libcloud/pull/1176)
    
    before:
    ```
    In [3]: conn.ex_create_image_member('a4f9cd7a-188a-444c-90a6-d24b8c688a63', 
'1d14ce09c41e4b53a3be31ff980d47e3')
    ...
    [u'Unexpected body type. Expected list/dict.<br /><br />\n\n\n', u'400 Bad 
Request', u'Bad Request']
    ```
    
    after:
    ```
    In [3]: conn.ex_create_image_member('a4f9cd7a-188a-444c-90a6-d24b8c688a63', 
'1d14ce09c41e4b53a3be31ff980d47e3')
    Out[3]: <NodeImageMember: id=1d14ce09c41e4b53a3be31ff980d47e3, 
image_id=a4f9cd7a-188a-444c-90a6-d24b8c688a63, state=pending, driver=OpenStack  
...>
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vdloo/libcloud 
fix-bug-in-sharing-images-openstack

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1190
    
----
commit 9d0f33a04aea659ff4b2787f5fa9d35cec997fbb
Author: Rick van de Loo <rickvandeloo@...>
Date:   2018-03-19T13:09:52Z

    fix unexpected body type openstack image sharing
    
    Looks like I introduced a bug here [in this 
PR](https://github.com/apache/libcloud/pull/1176)
    
    before:
    ```
    In [3]: conn.ex_create_image_member('a4f9cd7a-188a-444c-90a6-d24b8c688a63', 
'1d14ce09c41e4b53a3be31ff980d47e3')
    ...
    [u'Unexpected body type. Expected list/dict.<br /><br />\n\n\n', u'400 Bad 
Request', u'Bad Request']
    ```
    
    after:
    ```
    In [3]: conn.ex_create_image_member('a4f9cd7a-188a-444c-90a6-d24b8c688a63', 
'1d14ce09c41e4b53a3be31ff980d47e3')
    Out[3]: <NodeImageMember: id=1d14ce09c41e4b53a3be31ff980d47e3, 
image_id=a4f9cd7a-188a-444c-90a6-d24b8c688a63, state=pending, driver=OpenStack  
...>
    ```

----


---

Reply via email to