[ https://issues.apache.org/jira/browse/LIBCLOUD-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490332#comment-16490332 ]
ASF GitHub Bot commented on LIBCLOUD-997: ----------------------------------------- GitHub user micafer opened a pull request: https://github.com/apache/libcloud/pull/1215 Fix LIBCLOUD-997, implements LIBCLOUD-998 and LIBCLOUD-604 ## Fix LIBCLOUD-997, implements LIBCLOUD-998 and LIBCLOUD-604 ### Description #### LIBCLOUD-604: Add equivalent function for returning listed subnets in OpenStack driver. Similar to `ex_list_subnet` for EC2 endpoint providers. #### LIBCLOUD-997: The OpenStack_2_NodeDriver uses two connections the base class connection attribute and a new one: image_connection. In this case if the user has specified the ex_force_base_url one of them will fail, as both uses the same base url, but there are different services with different urls. If the user set the compute base url (the standard case) the image one will not work a viceversa #### LIBCLOUD-998: OpenStack_2_NodeDriver class uses the deprecated path "/os-networks" of the compute API instead of using the "/v2.0/networks" of the neutron API that i the current one. ### Status - done, ready for review ### Checklist (tick everything that applies) - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [x] Documentation - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/micafer/libcloud trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/1215.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1215 ---- commit 814bc3e366bdce7f2b935eeb3c7ed21d562cf3e8 Author: micafer <micafer1@...> Date: 2017-06-20T06:21:37Z Fix #LIBCLOUD-925 commit 7deee735c43b38e021153579d41193b49cbba1dd Author: micafer <micafer1@...> Date: 2017-11-29T12:37:11Z Merge remote-tracking branch 'upstream/trunk' into trunk commit 00efcf2be242acfa8821dec7c2ec14537a5f9584 Author: micafer <micafer1@...> Date: 2017-11-29T12:51:18Z Improve error message commit e23be01804d4d435382fb2dc2b1bf68ad0f5e401 Author: micafer <micafer1@...> Date: 2017-11-30T08:56:02Z Fix LIBCLOUD-965 commit 3dd6f4d5aec21f8d11e415fe4d95d2e316bb3dac Author: micafer <micafer1@...> Date: 2017-11-30T09:59:31Z Fix test commit 15ae45805dcef1d91498af33598ee5c2059c411a Author: micafer <micafer1@...> Date: 2017-12-18T09:21:24Z Merge remote-tracking branch 'upstream/trunk' into trunk commit ca38440afb003c30b884cd6e1afb15cfb163d0d6 Author: micafer <micafer1@...> Date: 2018-01-30T11:46:23Z Imrpove test commit 5deb1595eb110e1ae92db01f2579f6c68e062fd0 Author: Miguel Caballer <micafer1@...> Date: 2018-05-11T11:42:22Z Merge pull request #1 from apache/trunk Merge upstream commit a6c19b6ce97a6c7d151ede99627bcdc8f6590f12 Author: micafer <micafer1@...> Date: 2018-05-11T11:47:20Z return extra_specs in OpenStackNodeSize commit 271813f59cd9f0b5b67f829b4d5427fe62a352b7 Author: micafer <micafer1@...> Date: 2018-05-11T11:49:49Z return extra_specs in OpenStackNodeSize commit c7464b57dcc7e09fdfa01348de85f85046dac3a1 Author: micafer <micafer1@...> Date: 2018-05-25T07:05:49Z Fix LIBCLOUD-997, implements LIBCLOUD-998 and LIBCLOUD-604 ---- > OpenStack_2_ImageConnection does not work if ex_force_base_url is used > ---------------------------------------------------------------------- > > Key: LIBCLOUD-997 > URL: https://issues.apache.org/jira/browse/LIBCLOUD-997 > Project: Libcloud > Issue Type: Bug > Components: Compute > Reporter: Miguel Caballer > Priority: Major > > The OpenStack_2_NodeDriver uses two connections > the base class connection attribute and a new one: image_connection. > In this case if the user has specified the ex_force_base_url one of them will > fail, as both uses the same base url, but there are different services with > different urls. If the user set the compute base url (the standard case) the > image one will not work a viceversa > -- This message was sent by Atlassian JIRA (v7.6.3#76005)