GitHub user panlinux opened a pull request:
https://github.com/apache/libcloud/pull/1237
Convert object_size to string before adding it to a header.
## Convert object_size to string before adding it to a header.
### Description
Since python-requests 2.11
(see https://github.com/requests/requests/issues/3477), integer values
in headers are no longer automatically converted to strings, so we need
to do it ourselves.
This is the same change that was done a couple of lines above for the
Content-Length header in commit 28a559042.
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [ ] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [ ] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/panlinux/libcloud python-request-header-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1237.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1237
----
commit dbb98525a681defd3c5504066a3b29aa74443649
Author: Andreas Hasenack <andreas@...>
Date: 2018-08-28T12:41:54Z
Convert object_size to string before adding it to a header.
Since python-requests 2.11
(see https://github.com/requests/requests/issues/3477), integer values
in headers are no longer automatically converted to strings, so we need
to do it ourselves.
This is the same change that was done a couple of lines above for the
Content-Length header in commit 28a559042.
----
---
