GitHub user ktdreyer opened a pull request:

    https://github.com/apache/libcloud/pull/1261

    openstack: handle missing user "enabled" attribute

    ### Description
    
    Keystone may not always return an "enabled" attribute for a user account. 
Prior to this change, we could crash if we queried a user that lacked an 
"enabled" attribute. Gracefully handle this case by setting "enabled" to None.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ktdreyer/libcloud 
optional-enabled-openstack-user

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1261
    
----
commit 5155769bd431f332f89ee31387c97cbc42d44ebf
Author: Ken Dreyer <kdreyer@...>
Date:   2018-11-28T20:46:55Z

    openstack: handle missing user "enabled" attribute
    
    Keystone may not always return an "enabled" attribute for a user
    account. Prior to this change, we could crash if we queried a user that
    lacked an "enabled" attribute. Gracefully handle this case by setting
    "enabled" to None.

----


---

Reply via email to