GitHub user MonsieurV opened a pull request:
https://github.com/apache/libcloud/pull/1272
Handle Google Storage Interoperability access keys of more than 20
characters
## Fix _is_gcs_s3 to detect access keys of more than 20 characters
### Description
Google Cloud Storage currently emits access keys of more than 20 characters.
For e.g. an access key generated on my account (revoked since):
`GOOGDF5OVRRGU4APFNSTVCXI` (24 characters)
So we can't rely anymore [on the
doc](https://cloud.google.com/storage/docs/migrating?hl=fr#keys), when it is
stating:
> An access key is a 20 character alphanumeric string
### Status
- done, ready for review
Should we add tests?
### Checklist (tick everything that applies)
- [X] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [X] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MonsieurV/libcloud trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1272.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1272
----
commit c10350e2afbd682a241373f51eacf5a030a59e03
Author: Yoan Tournade <yoan@...>
Date: 2018-12-28T00:54:29Z
Fix _is_gcs_s3 to accept access keys of more than 20 chars
Google Cloud Storage currently emits access keys of more than 20 characters
----
---
