yukw777 commented on a change in pull request #1387: GCENodeDriver's
deploy_node() now accepts Deployments as well as all the parameters accepted by
create_node()
URL: https://github.com/apache/libcloud/pull/1387#discussion_r358411453
##########
File path: libcloud/compute/drivers/gce.py
##########
@@ -3995,7 +3995,7 @@ def create_node(
ex_on_host_maintenance=None, ex_automatic_restart=None,
ex_preemptible=None, ex_image_family=None, ex_labels=None,
ex_accelerator_type=None, ex_accelerator_count=None,
- ex_disk_size=None):
+ ex_disk_size=None, **kwargs):
Review comment:
I saw that other drivers like `ec2` and `azure` do this, so I followed their
pattern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
